-
Notifications
You must be signed in to change notification settings - Fork 80
Comparing changes
Open a pull request
base repository: cncf/xds
base: e9ce688
head repository: cncf/xds
compare: 0fa0005
- 8 commits
- 51 files changed
- 4 contributors
Commits on Oct 11, 2023
-
cel: add a description to the AST (#61)
Signed-off-by: Kuat Yessenov <kuat@google.com>
Configuration menu - View commit details
-
Copy full SHA for 776c4db - Browse repository at this point
Copy the full SHA 776c4dbView commit details
Commits on Oct 16, 2023
-
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8bd2eac - Browse repository at this point
Copy the full SHA 8bd2eacView commit details
Commits on Nov 9, 2023
-
bazel: fix "missing strict dependencies" build issue (#72)
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 523115e - Browse repository at this point
Copy the full SHA 523115eView commit details
Commits on Nov 16, 2023
-
bazel: Migrate py_proto_library to
@com_github_grpc_grpc
(#74)py_proto_library provided by @com_google_protobuf//:protobuf.bzl has been deprecated for a while now: This is provided for backwards compatibility only. Bazel 5.3 will introduce support for py_proto_library, which should be used instead. https://github.com/protocolbuffers/protobuf/blob/32af7d211b85f71920acdfa9b796db008f8c2a45/protobuf.bzl#L642-L644 However, native py_proto_library has never been provided, see bazelbuild/bazel#3935. Instead @rules_python//python:proto.bzl is recommended. I attempted switching to this library, but it's not compatible with @com_google_googleapis's py_proto_library targets, see #69. I found a hacky workaround by using cc_proto_library to generate python targets, but downstream integration into Envoy failed (envoyproxy/envoy#30159). This PR migrates py_proto_library implementation to to @com_github_grpc_grpc. This implementation is used by @com_google_googleapis's, and, more importantly, uses bazel aspects. Which decouples cncf/xds and Envoy's dependencies from concrete upstream py_proto_library implementations. This resulted in a significant code improvement of bazel/api_build_system.bzl: No more custom @com_google_googleapis dependency mapping needed via py_proto_library rules override. No more hardcoded dependencies _xds_py_proto_library - proto dependency tree is determined from proto_library definitions via Basel aspects. No more EXTERNAL_PROTO_PY_BAZEL_DEP_MAP dependency map needed - for the same reason. Similar work in Envoy: envoyproxy/envoy#30834. Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 3a472e5 - Browse repository at this point
Copy the full SHA 3a472e5View commit details
Commits on Nov 17, 2023
-
Add canonical CEL support: dev.cel.expr (#75)
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 0f5e0d9 - Browse repository at this point
Copy the full SHA 0f5e0d9View commit details
Commits on Nov 21, 2023
-
Revert "Add canonical CEL support: dev.cel.expr (#75)" (#79)
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 5b9bca5 - Browse repository at this point
Copy the full SHA 5b9bca5View commit details
Commits on Nov 27, 2023
-
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8e57aac - Browse repository at this point
Copy the full SHA 8e57aacView commit details
Commits on Nov 28, 2023
-
annotations: correct go_package (#80)
Signed-off-by: John Howard <howardjohn@google.com>
Configuration menu - View commit details
-
Copy full SHA for 0fa0005 - Browse repository at this point
Copy the full SHA 0fa0005View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e9ce688...0fa0005