这是indexloc提供的服务，不要输入任何密码
Skip to content

Add repositories good first issues link #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add repositories good first issues link #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/layout/common/ExternalLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const ExternalLink = (props: Props) => {
{!isUndefined(props.visibleExternalIcon) && props.visibleExternalIcon ? (
<div class="d-flex flex-row align-items-center">
{props.children}
<SVGIcon kind={SVGIconKind.ExternalLink} class={`ms-2 icon ${props.externalIconClassName}`} />
<SVGIcon kind={SVGIconKind.ExternalLink} class={`ms-1 icon ${props.externalIconClassName}`} />
</div>
) : (
<>{props.children}</>
Expand Down
8 changes: 8 additions & 0 deletions web/src/layout/common/itemModal/RepositoriesSection.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,11 @@
.linkContentWrapper {
max-width: calc(100% - 1.5rem);
}

.goodFirstBadge img {
margin-top: -3px;
}

.badges {
row-gap: 0.5rem;
}
14 changes: 12 additions & 2 deletions web/src/layout/common/itemModal/RepositoriesSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const RepositoryInfo = (props: RepoProps) => {
</div>
</ExternalLink>
<Show when={props.repository.primary || !isUndefined(props.repository.github_data)}>
<div class="d-flex align-items-center mt-2 mt-md-0">
<div class={`d-flex align-items-center flex-wrap flex-md-nowrap mt-2 mt-md-0 ${styles.badges}`}>
<Show when={props.repository.primary}>
<div
class={`me-2 badge border rounded-0 text-uppercase ${styles.badgeOutlineDark} ${styles.miniBadge}`}
Expand All @@ -65,10 +65,20 @@ const RepositoryInfo = (props: RepoProps) => {
</div>
</Show>
<Show when={!isUndefined(props.repository.github_data)}>
<div class={`badge border rounded-0 ${styles.badgeOutlineDark} ${styles.miniBadge}`}>
<div class={`badge border rounded-0 me-2 ${styles.badgeOutlineDark} ${styles.miniBadge}`}>
{props.repository.github_data!.license}
</div>
</Show>
<div class="d-none d-md-flex">
<ExternalLink
class={styles.goodFirstBadge}
href={`https://github.com/${formatRepoUrl(props.repository.url)}/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue"`}
>
<img
src={`https://img.shields.io/github/issues/${formatRepoUrl(props.repository.url)}/good%20first%20issue.svg?style=flat-square`}
/>
</ExternalLink>
</div>
</div>
</Show>
</div>
Expand Down