Grammar: replace "resolve to" with "resolve" #11276
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the grammar of error messages throughout the codebase by removing the preposition "to" from phrases like "could not resolve to" and replacing them with the more grammatically correct "could not resolve". The change addresses confusion where the phrasing made it appear as if an empty string was being concatenated into the error message.
- Updates error message strings to use "could not resolve" instead of "could not resolve to"
- Updates corresponding test expectations to match the new error message format
- Applies the change consistently across workflow, issue, repository, and organization-related error messages
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/cmd/workflow/shared/shared.go | Updates workflow resolution error message |
| pkg/cmd/workflow/enable/enable_test.go | Updates test expectation for workflow enable error |
| pkg/cmd/workflow/disable/disable_test.go | Updates test expectation for workflow disable error |
| pkg/cmd/label/clone_test.go | Updates test expectations for repository resolution errors |
| pkg/cmd/issue/view/view_test.go | Updates test expectations for issue resolution errors |
| pkg/cmd/issue/reopen/reopen_test.go | Updates test expectation for issue/PR resolution error |
| pkg/cmd/issue/edit/edit_test.go | Updates test expectation for issue resolution error |
| pkg/cmd/issue/delete/delete_test.go | Updates test expectations for issue resolution errors |
| pkg/cmd/issue/create/create_test.go | Updates test expectation for organization resolution error |
| pkg/cmd/issue/close/close_test.go | Updates test expectation for issue/PR resolution error |
| api/queries_repo_test.go | Updates test expectation for repository resolution error |
| api/queries_repo.go | Updates repository and organization error message constants and formatting |
| api/queries_org.go | Updates team resolution error message |
| acceptance/testdata/repo/repo-delete.txtar | Updates acceptance test expectation for repository deletion |
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
The phrasing "could not resolve to xyz" made me think an empty string was being pasted in, like
"Could not resolve " + input + " to...". Some debugging later, I discovered the string actually literally appears in the CLI. I suggest "resolve" should be used without "to" ("could not resolve a repository"). "Resolve abc to def" is fine, but I didn't find such usage here.