这是indexloc提供的服务，不要输入任何密码
Skip to content

Option to run with VNC #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2022
Merged

Option to run with VNC #97

merged 4 commits into from
May 23, 2022

Conversation

@fkorotkov
Copy link
Contributor

@fkorotkov fkorotkov commented May 20, 2022 •
edited
Loading

So copy/paste is working. For example, tart run --vnc latest.

Related to #14

@fkorotkov
Option to run with VNC
4dae314 
So copy/paste is working. For example, `tart run --vnc latest`.

Related to 14
@fkorotkov fkorotkov requested a review from edigaryev May 20, 2022 13:34
@fkorotkov fkorotkov enabled auto-merge (squash) May 20, 2022 15:04
edigaryev
edigaryev reviewed May 21, 2022
View reviewed changes
Sources/tart/Commands/Run.swift

@Flag var recovery: Bool = false

@Flag var vnc: Bool = false
Copy link
Collaborator

@edigaryev edigaryev May 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add an explanation on what this flag does, because someone might think that it configures and starts a VNC server automatically for them, which is not true.

Copy link
Contributor Author

@fkorotkov fkorotkov May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were too quick. Opened #100 with the followup on this

@edigaryev
Copy link
Collaborator

edigaryev commented May 21, 2022 •
edited
Loading

What do you think about adding an additional tart vnc command, which would allow opening multiple sessions to the VM and keeping the remote control available in case the original session was lost for some reason?

I'd even argue that this is the only thing that's needed, because the complications of the --vnc flag can already be seen in the fact that it implicitly enables --no-graphics, and there might be cases where this is not desired.

@fkorotkov fkorotkov merged commit 088cdc5 into main May 23, 2022
@fkorotkov fkorotkov deleted the vnc branch May 23, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edigaryev edigaryev edigaryev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fkorotkov @edigaryev