Make ARPCache to respect cancellation
#915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By manually handling `waitUntilExit` Tested by using `/bin/sleep 120` instead of `/usr/sbin/arp -an`.
edigaryev
reviewed
Oct 2, 2024
| process.waitUntilExit() | ||
| while process.isRunning { | ||
| if Task.isCancelled { | ||
| process.terminate() |
Collaborator
There was a problem hiding this comment.
It seems that this line won't be called 99.99% of the time, because Task.sleep() runs long enough and will throw a CancellationError on task cancellation, thus immediately exiting the loop.
Having a proper async Process() can be burdensome in Swift at the moment, and we have Process() in other places too, so what do you think about addressing the root cause instead? See #916.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By manually handling
waitUntilExitTested by using
/bin/sleep 120instead of/usr/sbin/arp -an.