tart push: re-try when encountering errors when pushing disk layers #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Aug 9, 2024
| _ = try await registry.pushBlob(fromData: compressedData, chunkSizeMb: chunkSizeMb, digest: compressedDataDigest) | ||
| } | ||
| } recoverFromFailure: { error in | ||
| if error is RuntimeError { |
Contributor
There was a problem hiding this comment.
Registry can also throw a RegistryError. I wonder if it makes sense to just narrow down the issue to a re-tryable HTTP/Network issue. For example, don't retry authorization. Or maybe retry all the Errors regadless. 🤔
Collaborator
Author
There was a problem hiding this comment.
I wonder if it makes sense to just narrow down the issue to a re-tryable HTTP/Network issue.
Implemented in 4191fef.
Also mirrored the same logic on the tart pull side of things.
a94b68e to
4191fef
Compare
fkorotkov
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #885.