这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@amalchuk
Copy link
Contributor

Partially closing #14.

Tested on Ubuntu 22.04, and works only on Linux VMs only for now.

@edigaryev
Copy link
Collaborator

Hello Andrew, thanks for the contribution!

Would you mind addressing the concerns expressed #202 (comment) in this PR too?

Or we can merge and then build add an option on top of this.

/cc @fkorotkov

@amalchuk
Copy link
Contributor Author

amalchuk commented Apr 29, 2024

What do you think about adding an "audio" option to the config.json file for this feature?
Or, another option in the CLI – such as "--no-audio", with an option called "--no-clipboard"?

Currently, every feature is enabled by default – audio, for example. If a user doesn't want to use any of the default features, they can choose to disable them with options.

I think enabling clipboard sharing by default is a good idea, but also providing an option to disable this feature with "--no-clipboard" would be useful. What do you think?

@edigaryev edigaryev merged commit 3ff3850 into cirruslabs:main May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants