Check all VMs for MAC collision #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before only suspendable VMs were getting checked. Not sure why. It makes sense to check all.
Collaborator
Because for the rest of the VMs we do this in tart/Sources/tart/Commands/Clone.swift Lines 65 to 67 in 9f38441 |
Contributor
Author
|
There was a report when a person just |
Collaborator
Let's acquire the global lock unconditionally then to simplify things up. |
Contributor
Author
|
SGTM. PTAL 2af05de |
edigaryev
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before only suspendable VMs were getting checked. Not sure why. It makes sense to check all.