Pass through env variables to credential helpers #490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
May 7, 2023
| let process = Process.init() | ||
| process.executableURL = executableURL | ||
| // pass environment variables so things like AWS_PROFILE are picked up | ||
| process.environment = ProcessInfo.processInfo.environment |
Collaborator
There was a problem hiding this comment.
I think this is a no-op:
By default, a Process object inherits its environment from the process that launches it.
(from https://developer.apple.com/documentation/foundation/process)
Contributor
Author
There was a problem hiding this comment.
My bad. Seems user should just switch to newer credHelpers.
Collaborator
|
Judging from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488