Doco fixups #350
Merged
Doco fixups #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
Dec 14, 2022
README.md
Outdated
|
|
||
| If the guest VM is running and configured to accept incoming SSH connections you can conveniently connect to it like so: | ||
| ```shell | ||
| ssh admin:admin@$(tart ip monterey-base) |
Collaborator
There was a problem hiding this comment.
I don't think it works like that: ssh will treat whole admin:admin as username.
Contributor
Author
There was a problem hiding this comment.
You're correct. I don't how I managed that 🤦 I use sshpass to do this personally. I'll fix it up.
edigaryev
previously approved these changes
Dec 14, 2022
fkorotkov
reviewed
Dec 14, 2022
Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>
fkorotkov
approved these changes
Dec 14, 2022
Contributor
|
Hey @marc-48k, We are preparing 1.0.0 release of Tart at some point in February and would like to clean things up and stabilize the API to provide long term support. Therefore we are introducing Contributor License Agreement which is common practice among mature OSS projects. Can we kindly ask you to sign the CLA using this link: https://cla-assistant.io/cirruslabs/tart If you have any question please don't hesitate to ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst getting up to speed with the project and making my first PR there were a few fixes, normalizations and additions I wanted to make.