Fix SwiftFormat's URL/glob mishandling #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
previously approved these changes
Nov 29, 2022
Contributor
fkorotkov
left a comment
There was a problem hiding this comment.
Weird it didn't error about missing config file 🤷♂️
This reverts commit 4d1a4c7.
Collaborator
Author
|
Seems like this is not going to work, a fix in the SwiftFormat is needed: nicklockwood/SwiftFormat#1317. I've pointed our |
Collaborator
Author
|
Bumped the Git SHA to accomodate another fix needed: nicklockwood/SwiftFormat#1317 (comment). |
fkorotkov
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the build on
main.