Refactored UI #22
Refactored UI #22
Conversation
| VMView(vm: vm!).onAppear { | ||
| NSWindow.allowsAutomaticWindowTabbing = false | ||
| } | ||
| }.frame(width: CGFloat(vm!.config.display.width), height: CGFloat(vm!.config.display.height)) |
There was a problem hiding this comment.
LGTM, but this one is a bit problematic: when the VM's display size is larger than the host's display size, the scaling would be badly needed, but this frame() makes it not possible.
Perhaps we can only enable this if the VM resolution is lower than host display resolution?
There was a problem hiding this comment.
Don't think it's a big concern since the default 1024x728 will fit in most of the screens. Your use case is only possible if someone will overwrite it to some obscure value, in that case a window will be still created and will be just cropped out. Person will need to close the window and set a proper display size for the host.
I decided to introduce the display config because before it was created the same size as the host's main screen and there was something odd with DPI which made it not quite freezable to use on my Retina MBP. Needed a magnifier! 😅
Before the window was too big and scaling was too little. This PR introduces
displaysettings with some meaningful defaults.Also cleared out the toolbar to not include standard Undo/Redo/etc options. And propagated VM name into title so it's easier to distinguish VMs from each other.