OCI blob compression: fix Data memory leak when using InputFilter #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Aug 17, 2022
Sources/tart/VMDirectory+OCI.swift
Outdated
| diskReadBytes += UInt64(data?.count ?? 0) | ||
| let mappedDisk = try Data(contentsOf: diskURL, options: [.alwaysMapped]) | ||
| let mappedDiskSize = mappedDisk.count | ||
| var mappedDiskOffset = 0 |
Contributor
There was a problem hiding this comment.
Maybe name it mappedDiskReadOffset?
Sources/tart/VMDirectory+OCI.swift
Outdated
| mappedDiskOffset += bytesRead | ||
|
|
||
| progress.completedUnitCount += Int64(data?.count ?? 0) | ||
| progress.completedUnitCount += Int64(bytesRead) |
Contributor
There was a problem hiding this comment.
Maybe just set it to mappedDiskOffset?
fkorotkov
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Tart use
mmap(2)-backedDataandInputFilter(.compress, ...)logic from Apple's documentation, which fixes the memory leak and results in smooth memory usage overall:(this shows a lifetime of a Tart instance that pushed a 120 GB disk to the registry)
Resolves #165.