OCI: support insecure registries and custom ports #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Aug 8, 2022
| baseURLComponents.host = host | ||
| baseURLComponents.path = "/v2/" | ||
| let proto = insecure ? "http" : "https" | ||
| let baseURLComponents = URLComponents(string: proto + "://" + host + "/v2/")! |
Contributor
There was a problem hiding this comment.
Can we just assume that post might contain either https or http and do something like:
var baseURL = host + "/v2/"
if !baseURL.contains("://") {
baseURL = "https://" + baseURL
}
let baseURLComponents = URLComponents(string: baseURL)!Will it be properly parsed from the upstream invocations?
Collaborator
Author
There was a problem hiding this comment.
We'd have to modify the OCI reference parser (RemoteName.swift) for this. And an OCI reference parser that accepts URLs and knows anything about protocol seems like a standard non-compliant thing that might bite us in the future.
It also seems weird once we allow https://ghcr.io/a/b syntax instead of ghcr.io/a/b, it might make someone think they can control the base URL, which this is not the case: the base URL will ignore /a/b, but will always include /v2/`.
fkorotkov
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be helpful for debugging against a local Docker Registry and also for #131.