OCI's HTTP client: prevent the usage of NIO Transport Services #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very interesting finding! Thank you for profiling it and finding the root cause. Is there any sense n using more then 1 thread for the group? Probably not since we don't do parallel requests explicitly but maybe internally there are some events that can be processed in parallel. 🤔 |
Collaborator
Author
I don't think it makes sense to bump it at this point since the performance is already quite good and it seems to be a safe choice given that AsyncHTTPClient uses 1 thread by default too. |
fkorotkov
approved these changes
Aug 1, 2022
Contributor
|
Do we need #159 as a feature now? 😅 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that:
NIOTSEventLoopGroup()as event loop groupNetwork.Framework...which behaves wildly inefficient for reasons that can't be diagnosed easily without getting source code access:
However, we can force the AsyncHTTPClient to take a different path by manually specifying the event loop group provider.
This seems to be a simpler and faster alternative than #159: I'm getting 10x the speed of
mainbranch and that of the chunked variant with way less CPU usage.Resolves #158, #165.