这是indexloc提供的服务，不要输入任何密码
Skip to content

Support chunked uploads #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2022
Merged

Support chunked uploads #159

merged 3 commits into from
Aug 8, 2022

Conversation

@fkorotkov
Copy link
Contributor

@fkorotkov fkorotkov commented Jul 28, 2022

@fkorotkov fkorotkov requested a review from edigaryev July 28, 2022 16:31
@fkorotkov
Copy link
Contributor Author

fkorotkov commented Jul 28, 2022

I've tested by uploading an image to ECR. Before the change it was barely doing anything, with the change I see 30-40 MB/s uploads. Will verify with GitHub Packages shortly too...

@fkorotkov
Copy link
Contributor Author

fkorotkov commented Jul 28, 2022

Just tried to push the latest Ventura beta to ghcr.io using the branch. Had to lower the chunk size and also fixed range end index (it's inclusive). See 6e3df64

@fkorotkov
Copy link
Contributor Author

fkorotkov commented Jul 28, 2022

But now ECR is not working with a 500 with no message. Seems the empty PUT is not working as expected. Will refactor to do the last put for the last chunk.

@fkorotkov
Copy link
Contributor Author

fkorotkov commented Jul 30, 2022

It appeared that not all registries support chunked uploads so I introduced a new --chunk-size option.

tart push --chunk-size=10 should fix #158 for @victor-yousician

@fkorotkov fkorotkov changed the title Chunked layer uploads Support chunked uploads Aug 1, 2022
@fkorotkov fkorotkov mentioned this pull request Aug 1, 2022
Closed
@edigaryev edigaryev mentioned this pull request Aug 1, 2022
Merged
@fkorotkov
Copy link
Contributor Author

fkorotkov commented Aug 1, 2022

Closing in favor of #168

@fkorotkov fkorotkov closed this Aug 1, 2022
@fkorotkov
Copy link
Contributor Author

fkorotkov commented Aug 2, 2022

Reopened for further discussion of this change being a feature rather then a bug fix.

@fkorotkov fkorotkov reopened this Aug 2, 2022
@fkorotkov fkorotkov merged commit e2b7f12 into main Aug 8, 2022
@fkorotkov fkorotkov deleted the upload-in-chunks branch August 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edigaryev edigaryev edigaryev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fkorotkov @edigaryev