Accept disk size > 255GB #122
Conversation
Sources/tart/Commands/Create.swift
Outdated
|
|
||
| @Option(help: ArgumentHelp("Disk size in Gb")) | ||
| var diskSize: UInt8 = 50 | ||
| var diskSize: Int = 50 |
There was a problem hiding this comment.
What do you think about UInt16? It will make the disk option up to 65 TB. Should be OK for a decade or so. 😅
There was a problem hiding this comment.
Good point. Updated the PR accordingly.
Sources/tart/Commands/Run.swift
Outdated
| if noGraphics || vnc { | ||
| dispatchMain() | ||
| } else { | ||
| runUI() | ||
| } |
There was a problem hiding this comment.
Could you please check if #123 works for you? With this change it seems UI won't be shown at all because it will wait for the group to finish aka VM stops.
There was a problem hiding this comment.
Ventura was too problematic to me, restored to Monterey now. Will find a M1 machine to test that. Withdrawn the commit and leave it for now.
There was a problem hiding this comment.
Just tried #123 , works except Windowed mode
|
Hey @keisau, We are preparing 1.0.0 release of Tart at some point in January and would like to clean things up and stabilize the API to provide long term support. Therefore we are introducing Contributor License Agreement which is common practice among mature OSS projects. Can we kindly ask you to sign the CLA using this link: https://cla-assistant.io/cirruslabs/tart If you have any question please don't hesitate to ask. |
UInt8->UInt16for supporting larger disk sizeOn Ventura,dispatchMaininsidewithThrowingTaskGroupresults in unexpected behaviors:Segmentation Faultfor--no-graphicsOtherwise, the VM screen shows up but the virtual machine process doesn't show up in Activity Monitor