tart set: support optional "pt" and "px" units for "--display" argument #1155
Conversation
There was a problem hiding this comment.
💡 Codex Review
tart/Sources/tart/Commands/Set.swift
Lines 52 to 58 in 9fc05a0
The new parser correctly recognizes pt/px suffixes, but run() only copies width and height into the VM config and drops the parsed unit. As a result a call like tart set --display 1920x1080px writes the same configuration as tart set --display 1920x1080, so vmConfig.display.unit remains nil and Darwin continues to treat the values as points. The new pixel hint never reaches Platform.Darwin.graphicsDevice, so the feature does not work. vmConfig.display.unit should be updated when the option is provided.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Thanks, fixed in 72b58b5. |
A simpler alternative to #1151, without introducing a new command-line argument.
Resolves #1150, closes #1151.