feat: prioritize pruning of old SHA when pulling updated tags #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pulling a new version of a tagged image (e.g., ghcr.io/cirruslabs/macos-runner:sonoma), set the access date of the previous SHA to epoch time (1970-01-01). This ensures that the old SHA will be prioritized for pruning, even if it was accessed more recently than other cached images. This helps manage disk space more efficiently by automatically cleaning up superseded versions of frequently-updated tagged images. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
edigaryev
reviewed
Jul 7, 2025
Sources/tart/VMStorageOCI.swift
Outdated
| let tmpVMDir = try VMDirectory.temporaryDeterministic(key: name.description) | ||
|
|
||
| // Check if there's an existing symlink pointing to a different digest | ||
| if exists(name) { |
Collaborator
There was a problem hiding this comment.
What do you think about simplifying this down to:
// Open an existing VM directory corresponding to this name, if any,
// marking it as outdated to speed up the garbage collection process
_ = try? open(name, Date(timeIntervalSince1970: 0))The open() will need to be adjusted as follows:
diff --git a/Sources/tart/VMStorageOCI.swift b/Sources/tart/VMStorageOCI.swift
index 764eb1e..f71c547 100644
--- a/Sources/tart/VMStorageOCI.swift
+++ b/Sources/tart/VMStorageOCI.swift
@@ -27,12 +27,12 @@ class VMStorageOCI: PrunableStorage {
return digest
}
- func open(_ name: RemoteName) throws -> VMDirectory {
+ func open(_ name: RemoteName, _ accessDate: Date = Date()) throws -> VMDirectory {
let vmDir = VMDirectory(baseURL: vmURL(name))
try vmDir.validate(userFriendlyName: name.description)
- try vmDir.baseURL.updateAccessDate()
+ try vmDir.baseURL.updateAccessDate(accessDate)
return vmDir
}
Contributor
Author
There was a problem hiding this comment.
@edigaryev are you sure symlink will update access time of the original sha folder?
edigaryev
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling a new version of a tagged image (e.g., ghcr.io/cirruslabs/macos-runner:sonoma), set the access date of the previous SHA to epoch time (1970-01-01). This ensures that the old SHA will be prioritized for pruning, even if it was accessed more recently than other cached images.
This helps manage disk space more efficiently by automatically cleaning up superseded versions of frequently-updated tagged images.
🤖 Generated with Claude Code