tart ip: implement --resolver=agent #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
approved these changes
Jun 18, 2025
| do { | ||
| return try await resolveIP(controlSocketURL) | ||
| } catch let error as GRPCConnectionPoolError { | ||
| return nil |
Contributor
There was a problem hiding this comment.
Should we log the error? Like agent is not installed or something.
Collaborator
Author
There was a problem hiding this comment.
We give a hint here:
tart/Sources/tart/Commands/IP.swift
Line 43 in 5e06340
Not sure about logs, though, because other resolvers don't log anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cirruslabs/tart-guest-agent#14.