这是indexloc提供的服务，不要输入任何密码
Skip to content

Basic CLI implementation that wraps Virtualization.Framework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2022
Merged

Basic CLI implementation that wraps Virtualization.Framework #1

merged 4 commits into from
Feb 14, 2022

Conversation

@edigaryev
Copy link
Collaborator

@edigaryev edigaryev commented Feb 11, 2022

To run this, create a tart.entitlements file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.security.virtualization</key>
	<true/>
</dict>
</plist>

Sign the tart binary:

codesign --sign - --entitlements tart.entitlements --force tart

@edigaryev edigaryev requested a review from fkorotkov February 11, 2022 14:43
fkorotkov
fkorotkov reviewed Feb 12, 2022
View reviewed changes
Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is a need to store the Ram at all. VMs start super fast on my M1 Max so I wonder if we'll ever need the suspension mechanism at all and it seems it was causing only issues in Parallels and Anka (specifically the time and network portability).

Sources/tart/VMConfig.swift Outdated
var version: Int = 0
var ecid: VZMacMachineIdentifier
var hardwareModel: VZMacHardwareModel
var cpuCountMin: Int
Copy link
Contributor

@fkorotkov fkorotkov Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it's actually min. I was able to change it in the config from 2 to 4 and back. Every time VM was picking up the proper CPU count. I think it should be just cpuCoun.

Copy link
Collaborator Author

@edigaryev edigaryev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 8375e3c.

Sources/tart/VMConfig.swift Outdated
var ecid: VZMacMachineIdentifier
var hardwareModel: VZMacHardwareModel
var cpuCountMin: Int
var memorySizeMin: UInt64
Copy link
Contributor

@fkorotkov fkorotkov Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Plus I think it's better to store it in Mb and not bytes. Easier for humans. 😅

Copy link
Collaborator Author

@edigaryev edigaryev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 8375e3c.

Copy link
Collaborator Author

@edigaryev edigaryev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the units, I believe the conversion should be implemented in the CLI itself, because we already have things like ecid and hardwareModel in the configuration file do not make it any easier for humans already.

Sources/tart/VMConfig.swift Outdated
}

func save(toURL: URL) throws {
try JSONEncoder().encode(self).write(to: toURL)
Copy link
Contributor

@fkorotkov fkorotkov Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's save it in a pretty format:

encoder.outputFormatting = .prettyPrinted

Copy link
Collaborator Author

@edigaryev edigaryev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 348d977.

Sources/tart/VMDirectory.swift Outdated
Comment on lines 9 to 11
var configURL: URL { self.baseURL.appendingPathComponent("config") }
var diskURL: URL { self.baseURL.appendingPathComponent("disk") }
var nvramURL: URL { self.baseURL.appendingPathComponent("nvram") }
Copy link
Contributor

@fkorotkov fkorotkov Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about having config.json, disk.bin and ram.bin?

Copy link
Collaborator Author

@edigaryev edigaryev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 6fc868e.

@edigaryev
Copy link
Collaborator Author

edigaryev commented Feb 14, 2022

I wonder if there is a need to store the Ram at all. VMs start super fast on my M1 Max so I wonder if we'll ever need the suspension mechanism at all and it seems it was causing only issues in Parallels and Anka (specifically the time and network portability).

Are you talking about RAM size?

Because we're not storing the RAM itself at the moment.

@edigaryev edigaryev requested a review from fkorotkov February 14, 2022 14:06
@edigaryev edigaryev merged commit 2c7217f into main Feb 14, 2022
@edigaryev edigaryev deleted the basic-implementation branch February 14, 2022 15:56
@edigaryev edigaryev mentioned this pull request Apr 7, 2022
Merged
@remarkov remarkov mentioned this pull request Oct 14, 2022
Closed
@peternguyen93 peternguyen93 mentioned this pull request Jan 11, 2023
Merged
@bjordanov4 bjordanov4 mentioned this pull request Aug 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edigaryev @fkorotkov