helm: use CSIDriver.seLinuxMount parameter in templates #5303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@alelindq, Thanks for noticing and sending the PR. |
62ac9c5 to
17aef17
Compare
Contributor
Author
|
@iPraveenParihar fixed the commit format now |
nixpanic
previously approved these changes
May 7, 2025
Contributor
|
@alelindq , fix this too 😄 |
17aef17 to
b05b961
Compare
Member
nixpanic
approved these changes
May 7, 2025
iPraveenParihar
approved these changes
May 7, 2025
Contributor
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0cb6771 |
Commit 88ce2c6 removed a EOL kubernetes version check, but also the usage of Values.CSIDriver.seLinuxMount. This commit makes CSIDriver.seLinuxMount configurable from helm parameter, since the default for csidrivers.storage.k8s.io.spec.seLinuxMount is false, but do not change the template default value which is set to true in values.yaml. Signed-off-by: Alexander Lindquister <alelindq@cisco.com>
b05b961 to
adfc2c7
Compare
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.30 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 88ce2c6 removed a EOL kubernetes version check, but also the usage of Values.CSIDriver.seLinuxMount.
This commit makes CSIDriver.seLinuxMount configurable from helm parameter, since the default for csidrivers.storage.k8s.io.spec.seLinuxMount is false, but do not change the template default value which is set to true in values.yaml.