doc: clarifiy NVMe-oF design a little more #5422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After collecting feedback, it has been confirmed that the Ceph-CSI/RBD component can be used to create the RBD-images. The NVMe Subsystems may not have been pre-created, so Ceph-CSI should verify if the subsystem exists, and create it if needed. Note: also corrected some of the markdown-linter complaints. Signed-off-by: Niels de Vos <ndevos@ibm.com>
770f9d5 to
bffdf3f
Compare
Rakshith-R
approved these changes
Jul 10, 2025
Madhu-1
reviewed
Jul 10, 2025
| - NVMe-oF Gateway Group (hostname, could be a Kubernetes Service) | ||
| - NVMe subsystem name | ||
| - if given, the name for the subsystem should be used | ||
| - if not given, base the name on the owner (Kubernetes Namespace) |
Collaborator
There was a problem hiding this comment.
can we make this as mandatory in the SC so that we dont need to worry about it in other CO? or add a comment in other CO its a mandatory field
Member
Author
There was a problem hiding this comment.
I think it can be optional in a StorageClass, as we can detect the owner in Kubernetes clusters. For other platforms (Docker Swarm, Hashicorp Nomad, ..) it should be mandatory. I think it is sufficiently clear in the document?
Collaborator
There was a problem hiding this comment.
That last part that its mandatory for other CO was not mentioned, as this also need more PR for open questions, it can be addressed later
Madhu-1
approved these changes
Jul 10, 2025
Collaborator
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d97f3cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After collecting feedback, it has been confirmed that the Ceph-CSI/RBD
component can be used to create the RBD-images.
The NVMe Subsystems may not have been pre-created, so Ceph-CSI should
verify if the subsystem exists, and create it if needed.