fix: Tracevol now correctly parses hexadecimal pool id #5451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
@jggc can you please fix commitlint issue |
Pool id is a hex string, the previous `int(pool_id)` call fails when there is more than 10 pools in the cluster. Signed-off-by: Jean-Gab <jeangabriel.gc@gmail.com>
nixpanic
approved these changes
Aug 7, 2025
Member
|
@jggc, thanks for the PR! I've taken the liberty to correct the commit message. This should be ready for merging now. |
Madhu-1
approved these changes
Aug 7, 2025
Collaborator
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 54a1c1f |
Contributor
Author
Sorry about the delay, I almost never check my github notifs 😅 Thanks for the fix and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool id is a hex string, the previous
int(pool_id)call fails when there is more than 10 pools in the cluster.Describe what this PR does
Fix the parsing of pool id in tracevol.py utility
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)