-
Notifications
You must be signed in to change notification settings - Fork 34
helm: remove csi RBAC from the operator #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CSI template and RBAC's are shipped as another charts. we dont need to add the csi RBAC to the operator charts. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
f1bbf94 to
f06bb24
Compare
|
What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it? |
@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts |
Rook doesn't currently install the csi-driver chart, only the csi-operator chart. Can this be factored out as a helm library so the rbac can still come with the csi-operator chart? |
Having this in csi-operator chart is not a good idea because this are per drivers not for the operator. I need to look into this one and also we need to talk about long term look plan as well, What we have discussed was that Rook will move the CSI to the user management and not to generate(manage) the Csi-operator CR's. |
|
To summarize our discussion:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
|
not stale |
CSI template and RBAC's are shipped as another charts. we dont need to add the csi RBAC to the operator charts.