这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Sep 19, 2025

CSI template and RBAC's are shipped as another charts. we dont need to add the csi RBAC to the operator charts.

@Madhu-1 Madhu-1 requested a review from nb-ohad September 19, 2025 08:43
CSI template and RBAC's are shipped
as another charts. we dont need to add the
csi RBAC to the operator charts.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@travisn
Copy link
Member

travisn commented Sep 19, 2025

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 19, 2025

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

@travisn
Copy link
Member

travisn commented Sep 19, 2025

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

Rook doesn't currently install the csi-driver chart, only the csi-operator chart. Can this be factored out as a helm library so the rbac can still come with the csi-operator chart?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 22, 2025

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

Rook doesn't currently install the csi-driver chart, only the csi-operator chart. Can this be factored out as a helm library so the rbac can still come with the csi-operator chart?

Having this in csi-operator chart is not a good idea because this are per drivers not for the operator. I need to look into this one and also we need to talk about long term look plan as well, What we have discussed was that Rook will move the CSI to the user management and not to generate(manage) the Csi-operator CR's.

@travisn
Copy link
Member

travisn commented Sep 29, 2025

To summarize our discussion:

  • In the next minor release of Rook (v1.19), Rook will add a helm dependency on the csi drivers chart.
  • This RBAC change will not be made until the CSI operator 1.0 release (which is when Rook v1.19 will consume it)
  • Note that csi drivers chart is for creating the csi CRs (and is not related to the old csi drivers chart)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 30, 2025
@travisn
Copy link
Member

travisn commented Nov 3, 2025

not stale

@github-actions github-actions bot removed the stale label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants