feat: Callback operation adds IM connection function #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68d0f81 to
2f5dbde
Compare
710leo
reviewed
Jun 13, 2024
710leo
reviewed
Jun 13, 2024
2f5dbde to
74886e6
Compare
Reditiny
pushed a commit
to Reditiny/nightingale
that referenced
this pull request
Sep 3, 2024
…back resend (ccfos#1992) * feat: Callback operation adds IM connection function (ccfos#1984) * refactor: change alert sub callback --------- Co-authored-by: Yang Zhiyan <101268302+Yziyan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR simplifies the configuration of notification media for alert rules in Nightingale. Previously, users had to configure notification media separately, which was inconvenient and time-consuming. With this PR, users can directly configure the message dispatch to the desired notification media (such as DingTalk, Feishu, Feishu Card, WeCom, etc.) in the alert rule interface. This enhancement reduces the configuration cost and improves the user experience by providing a more streamlined and efficient setup process.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Please review the changes to ensure the new configuration interface is intuitive and user-friendly. Additionally, verify that the integration with various IM notification media works as expected across different use cases.