Correct test to identify methods with parameter 'identifier' #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current condition compares the length of $m to 1, which will never happen as setting $m = $method_map[...] ensures that it will be at least three. Thus processing drops into "else" clause, generating a PHP error for those methods (get_transaction_details and get_recurring_profile) that should have been captured by the "if" clause. The proposed solution is not perfect. The 2nd condition is arguably redundant as there are no methods with a single parameter that is not 'identifier'. Conversely it won't deal with these two methods being called with superfluous parameters. However, it would at least avoid errors when they're called correctly.
calvinfroedge
added a commit
that referenced
this pull request
Oct 29, 2012
Correct test to identify methods with parameter 'identifier'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current condition tests whether the length of the $m array has a single entry. However, this will never happen as setting $m = $method_map[...] immediately above ensures that it will always contain a minimum of 3 entries.
Thus processing will always drop into "else" clause, generating a PHP error for those methods (get_transaction_details and get_recurring_profile) that should have been dealt with by the "if" clause.
The proposed solution is not perfect. The 2nd condition is arguably redundant as there are no methods with a single parameter that is not 'identifier'. Conversely it won't deal with these two methods being called with superfluous parameters. However, it would at least avoid errors when they're called correctly, with no adverse effects for calls to other methods.