Migrate finish_time_millis and start_time_millis #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate finish_time_millis and start_time_millis from event_parser, accumulator, and build_logs_test buildbuddy-io/buildbuddy-internal#1162
cdde380 to
061da3b
Compare
bduffany
requested changes
Feb 14, 2022
| "github.com/buildbuddy-io/buildbuddy/server/util/status" | ||
| "github.com/google/uuid" | ||
| "github.com/stretchr/testify/require" | ||
| "google.golang.org/protobuf/types/known/timestamppb" |
Member
There was a problem hiding this comment.
We usually use "github.com/golang/protobuf/ptypes" (from "@com_github_golang_protobuf//ptypes:go_default_library_gen") and then ptypes.TimestampProto to get an instance of timestamp from a time.Time.
There's an open issue to migrate to google.golang.org/protobuf, I think, but for now we probably want to use the old package everywhere.
Contributor
Author
There was a problem hiding this comment.
I already introduced timestamppb and durationpb in earlier PRs. I think we can at least start to migrate to timestamppb and durationpb from ptypes.
bduffany
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate finish_time_millis and start_time_millis from event_parser, and
build_logs_test
https://github.com/buildbuddy-io/buildbuddy-internal/issues/1162