这是indexloc提供的服务，不要输入任何密码
Skip to content

Upgrade rules_go, gazelle and rules_proto #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

Upgrade rules_go, gazelle and rules_proto #6772

merged 1 commit into from
Jun 13, 2024

Conversation

@sluongng
Copy link
Contributor

@sluongng sluongng commented Jun 11, 2024 •
edited
Loading

Upgrade rules_go to v0.48.0.

This requires us to use the latest release of rules_proto (v6.0.0).
However, our rules_proto declaration was being shadowed by another rule's transitive dependencies.
Move rules_proto http_archive declarations up to avoid shadow-ing.

The latest version of rules_proto depends on bazel_features repo, but did not declare this as a transitive deps, so we also need to add that to our WORKSPACE setup.
The BzlMod setup has the correct transitive deps declaration so there is no need for it.

@sluongng sluongng force-pushed the sluongng/rules-go-48.0 branch from 8728b8f to 0a3afa5 Compare June 11, 2024 15:15
@sluongng sluongng changed the title sluongng/rules go 48.0 Upgrade rules_go and rules_proto Jun 11, 2024
@sluongng sluongng changed the title Upgrade rules_go and rules_proto Upgrade rules_go, gazelle and rules_proto Jun 11, 2024
@sluongng sluongng marked this pull request as ready for review June 11, 2024 16:24
@sluongng
Copy link
Contributor Author

sluongng commented Jun 11, 2024

hmmm... this is pretty noisy... gona need to split it into smaller PRs.

@sluongng sluongng marked this pull request as draft June 11, 2024 16:50
@sluongng
Copy link
Contributor Author

sluongng commented Jun 11, 2024 •
edited
Loading 

sluongng/rules-go-48.0 ~/work/buildbuddy/buildbuddy> bazel clean
INFO: Starting clean (this may take a while). Consider using --async if the clean takes more than several minutes.
sluongng/rules-go-48.0 ~/work/buildbuddy/buildbuddy> bazel build //proto/...
INFO: Streaming build results to: https://app.buildbuddy.io/invocation/5f25b093-1b00-4349-b5b3-fb5e41fac98a
ERROR: /private/var/tmp/_bazel_sluongng/06e573a93bc2d6a9cad4ad41f00b4310/external/com_google_protobuf/third_party/utf8_range/BUILD.bazel:32:11: Compiling third_party/utf8_range/utf8_range.c [for tool] failed: absolute path inclusion(s) found in rule '@@com_google_protobuf//third_party/utf8_range:utf8_range':
the source file 'third_party/utf8_range/utf8_range.c' includes the following non-builtin files with absolute paths (if these are builtin files, make sure these paths are in your toolchain):
  '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/15.0.0/include/stddef.h'
  '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/15.0.0/include/__stddef_max_align_t.h'
  '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/15.0.0/include/stdint.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdint.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_int8_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_int16_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_int32_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_int64_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_uint8_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_uint16_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_uint32_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_uint64_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_symbol_aliasing.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_posix_availability.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/machine/_types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/arm/_types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_pthread/_pthread_types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_intptr_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/machine/types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/arm/types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_u_int8_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_u_int16_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_u_int32_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_u_int64_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_uintptr_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_intmax_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types/_uintmax_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/string.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_types.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/Availability.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/AvailabilityVersions.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/AvailabilityInternal.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/AvailabilityInternalLegacy.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_null.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_rsize_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_errno_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_ssize_t.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/strings.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_strings.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_common.h'
  '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_string.h'
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.956s, Critical Path: 0.11s
INFO: 334 processes: 333 internal, 1 darwin-sandbox.
ERROR: Build did NOT complete successfully
INFO: Streaming build results to: https://app.buildbuddy.io/invocation/5f25b093-1b00-4349-b5b3-fb5e41fac98a
exit 1

Something weird about this error as well on my MacOS... not sure why upgrading rules_proto could cause a cc toolchain issue.

NVM, this was a local Xcode issue of mine after messing with it to compare against the MacOS executors environment. Note to future me: Restored with sudo xcode-select -s /Library/Developer/CommandLineTools

@sluongng sluongng mentioned this pull request Jun 11, 2024
Merged
@sluongng sluongng force-pushed the sluongng/rules-go-48.0 branch 2 times, most recently from dfb04d5 to 221ad56 Compare June 13, 2024 09:20
@sluongng sluongng force-pushed the sluongng/rules-go-48.0 branch from 221ad56 to e8b0637 Compare June 13, 2024 09:33
@sluongng sluongng requested review from bduffany and fmeum June 13, 2024 09:34
@sluongng sluongng marked this pull request as ready for review June 13, 2024 09:35
@sluongng sluongng merged commit b6369c6 into master Jun 13, 2024
@sluongng sluongng deleted the sluongng/rules-go-48.0 branch June 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

@bduffany bduffany Awaiting requested review from bduffany

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sluongng @fmeum