Better loading state for code viewer #6787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
approved these changes
Jun 12, 2024
Co-authored-by: Brandon Duffany <brandon@buildbuddy.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the loading state and a lot of error states for the code viewer just show the "Welcome to BuildBuddy Code" message.
This PR improves that by showing a loading spinner during bytestream fetches and handles some error cases better by showing red toast.
Pulls coverage handling into a showLcov function to make it more similar to
showBytestreamCompareandshowBytestreamFile.Also improves viewing coverage view without a GitHub link (prompts you to link GitHub).