fix(kubernetes): Only filter out files that contain Helm built-in variables and functions #6922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achiar99
approved these changes
Dec 29, 2024
rotemavni
approved these changes
May 26, 2025
Collaborator
|
Hello @eirmich, |
Saarett
pushed a commit
that referenced
this pull request
May 27, 2025
…iables and functions (#6922) * Filter out files that contain Helm built-in variables and functions * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Currently Kubernetes files that contain
{{are assumed to be part of a Helm chart, which in turn excludes them from analysis. However, this is not always the case, an example as described in #5643 (comment).This PR filters out only files that include Helm built-in variables or functions, namely
.Release,.Values,if,endandwith.Fixes #5643
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Modifies the Kubernetes YAML parser to improve the detection of Helm templates. Updates the
loadfunction ink8_yaml.pyto use regex patterns for identifying Helm-specific variables and functions, replacing the previous simple check for '{{'. Adds a new test case intest_k8_yaml.pyto verify the handling of non-Helm templates, and includes a sample YAML file for testing.Modified files (1)
Latest Contributors(2)
Modified files (2)
Latest Contributors(2)