feat(terraform_plan): support scanning deleted resources #7367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was not possible to check a resource's configuration when the plan indicated the resource would be deleted entirely. This prevented custom checks from enforcing conventions around deletions. We now process pure delete actions from resource_changes. The "before" state is made available as the resource configuration, with __change_actions__ set to ["delete"].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkov's Terraform plan scanning previously only processed resources from
planned_values, which excludes resources being purely deleted (action["delete"]).This prevented custom checks from validating deletion conditions (e.g., ensuring a resource is in an acceptable state before removal).
This PR extends the plan parser to extract resources with pure delete actions from
resource_changesand make them available to policy checks.The resource's "before" state is used as the configuration, with
__change_actions__set to["delete"].This would allow a policy to enforce specific resources attribute values before resource deletion.
Fixes #5587
Checklist: