这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(terraform): get_resource_tags handles more cases #7365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix(terraform): get_resource_tags handles more cases #7365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions checkov/terraform/tag_providers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,20 @@ def get_resource_tags(resource_type: str, entity_config: Dict[str, Any]) -> Opti
if not isinstance(entity_config, dict):
return None

if "_" not in resource_type:
return None # probably not a resource block
provider = resource_type[: resource_type.index("_")]
provider_tag_function = provider_tag_mapping.get(provider)
provider_tag = get_provider_tag(resource_type)
provider_tag_function = provider_tag_mapping.get(provider_tag) if provider_tag else None
if provider_tag_function:
return provider_tag_function(entity_config)
else:
return None


def get_provider_tag(resource_type: str) -> Optional[str]:
provider_tag = None
if 'aws' in resource_type:
provider_tag = "aws"
elif 'azure' in resource_type:
provider_tag = "azure"
elif 'gcp' in resource_type or 'google' in resource_type:
provider_tag = "gcp"
return provider_tag
13 changes: 13 additions & 0 deletions tests/terraform/test_provider_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import pytest

from checkov.terraform.tag_providers import get_provider_tag


@pytest.mark.parametrize("resource_type, expected", [
("aws_instance.example", "aws"),
("module.test.aws_instance.example", "aws"),
("azure_instance.example", "azure"),
("google_instance.example", "gcp"),
])
def test_get_provider_tag(resource_type, expected) -> None:
assert get_provider_tag(resource_type) == expected
Loading