fix(docker): add git url override support for github ssh-urls #7357
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @eriweb , what is the consequence of re-writing ssh urls to https security-wise ? |
Author
|
@maxamel Sorry for the late reply, the notification got lost. I'm not entirely sure what kind of consequences there would be. Both protocols are encrypted and should be safe to use. I do however see that there might be unintended errors because the behavior might be unexpected. Would introducing a more specific environment variable be better? Something like GITHUB_OVERRIDE_SSH_URL or similar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The Docker image provides support to override GitHub HTTPS URLs to use a PAT / token authentication to download private repositories. There is however no support to do the same with SSH URLs.
This PR changes that by rewriting SSH URLs to HTTPS.
Fixes # (issue)
bridgecrewio/checkov-action#178
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: