这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(general): Fix downloading of the external modules when ref is a shortened Git hash #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 4, 2025
Merged

feat(general): Fix downloading of the external modules when ref is a shortened Git hash #7278

merged 7 commits into from
Nov 4, 2025

Conversation

@viralpoetry
Copy link
Contributor

@viralpoetry viralpoetry commented Aug 22, 2025

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

When external modules are pulled by using shortened version of the git hash, checkov fails to pull it and outputs:

2025-08-06 13:19:38,194 [MainThread  ] [WARNI]  failed to get git::https://github.com/rynkowsg/tf-modules?ref=f6a8868 in git loader because of Cmd('git') failed due to: exit code(128)                                                                      
  cmdline: git clone -v --depth=1 -b f6a8868 -- https://github.com/rynkowsg/tf-modules <my-repo-full-path>/.external_modules/github.com/rynkowsg/tf-modules/f6a8868                                                         
  stderr: 'Cloning into '<my-repo-full-path>/.external_modules/github.com/rynkowsg/tf-modules/f6a8868'...                                                                                                                   
POST git-upload-pack (356 bytes)                                                                                                                                                                                                                             
fatal: Remote branch f6a8868 not found in upstream origin

Fixes #7267

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

Change regex to accept shortened version of a commit hash

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@viralpoetry
Copy link
Contributor Author

viralpoetry commented Sep 27, 2025

@maxamel hi, I am using this change locally, it works for both shortened and full commit sha digests. It helped a lot on a huge ~7 years old terraform monorepo.

@maxamel
Copy link
Contributor

maxamel commented Oct 12, 2025

@viralpoetry thanks for the contribution, can you add a test for this?

@viralpoetry
Copy link
Contributor Author

viralpoetry commented Oct 17, 2025

@maxamel hi, I have added test which verify that the function is working properly for shorter sha digest.

@maxamel maxamel changed the title Fix downloading of the external modules when ref is a shortened Git hash feat(general): Fix downloading of the external modules when ref is a shortened Git hash Nov 4, 2025
@maxamel maxamel merged commit 57acbb2 into bridgecrewio:main Nov 4, 2025
43 of 44 checks passed
Saarett pushed a commit that referenced this pull request Nov 4, 2025
@viralpoetry @maxamel @actions-user
feat(general): Fix downloading of the external modules when ref is a …
14402dc 
…shortened Git hash (#7278)

* Allow downloading of the external modules when ref is a shortened Git commit hash

* Test parsing of the shortened commit id.

---------

Co-authored-by: Max Amelchenko <maxamel2002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvalmich yuvalmich yuvalmich approved these changes

@bo156 bo156 bo156 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checkov fails to download external modules when ref is a Git commit hash

4 participants

@viralpoetry @maxamel @yuvalmich @bo156