fix(terraform): fix cloning external modules from private regsitries #7229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalmich
approved these changes
Jul 9, 2025
bo156
reviewed
Jul 9, 2025
lirshindalman
approved these changes
Jul 9, 2025
bo156
approved these changes
Jul 9, 2025
Saarett
pushed a commit
that referenced
this pull request
Jul 9, 2025
…7229) * fix cloning external modules from private regsitries * remove comments * change documentation comment * add tests for github is matching loader --------- Co-authored-by: Yuval Michaeli <ymichaeli@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Private Git registries used RegistryLoader instead of GitLoader.
This fix ensures, the right loader is matched to each source
Checklist: