这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(terraform): fix issue 7216 module version parsing issue #7224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 9, 2025
Merged

fix(terraform): fix issue 7216 module version parsing issue #7224

merged 19 commits into from
Jul 9, 2025

Conversation

tjwald
Copy link
Contributor

@tjwald tjwald commented Jul 1, 2025

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Changed load_modules to use cached hcl2 loaded ast instead of regex for version loading.

Fixes #7216

Fix

Fixes how we parse version information so that it is more robust.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@tjwald
fix mypy
9217f02 
& dogfood try #3
@tjwald
fix mypy #3
25e9eb5 
and excluded paths #4
SteveVaknin
SteveVaknin approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤖

@tjwald tjwald force-pushed the feature/CKV-7216-module-version-fix branch from 8829073 to 0186779 Compare July 7, 2025 15:03
@tjwald tjwald temporarily deployed to scan-security July 9, 2025 08:14 — with GitHub Actions Inactive
@tjwald tjwald merged commit 9c025df into main Jul 9, 2025
46 checks passed
@tjwald tjwald deleted the feature/CKV-7216-module-version-fix branch July 9, 2025 10:49
Saarett pushed a commit that referenced this pull request Jul 9, 2025
@tjwald @actions-user
fix(terraform): fix issue 7216 module version parsing issue (#7224)
a10dcd2 
* initial commit

* use already parsed hcl2 asts

* fixed issue with loading hcl or die

* code cleanup

* use standard parallel processing

* skip bad test
@sourcery-ai sourcery-ai bot mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo156 bo156 bo156 approved these changes

@SteveVaknin SteveVaknin SteveVaknin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module version parsing is too broad
3 participants
@tjwald @bo156 @SteveVaknin