这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(terraform): Multiple fixes #7178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

fix(terraform): Multiple fixes #7178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27a9c0d
Fix CKV2_AWS_52
tsmithv11 May 22, 2025
7272b2d
Merge branch 'main' into check-fixes-may25
tsmithv11 May 22, 2025
00bd1fa
Fix conda
tsmithv11 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Results will appear under [actions](https://github.com/bridgecrewio/checkov/acti
To run tests locally use the following commands (install dev dependencies, run tests and compute tests coverage):
If you are using conda, create a new environment with Python 3.10.14 version:
```sh
conda create -n python310 --m python=Python 3.10.14
conda create -n python310 python=3.10.17
conda activate python310
```
Then, we need pipenv installation and run the tests and coverage modules
Expand Down
2 changes: 1 addition & 1 deletion checkov/terraform/checks/graph_checks/aws/OpenSearchDomainHasFineGrainedControl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ metadata:
name: "Ensure AWS ElasticSearch/OpenSearch Fine-grained access control is enabled"
category: "IAM"
definition:
and:
or:
- cond_type: "attribute"
resource_types:
- "aws_opensearch_domain"
Expand Down
2 changes: 1 addition & 1 deletion tests/terraform/graph/checks/resources/OpenSearchDomainHasFineGrainedControl/expected.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
pass:
- "aws_elasticsearch_domain.es_pass"
- "aws_opensearch_domain.os_pass"
- "aws_opensearch_domain.os_pass1"
fail:
- "aws_opensearch_domain.os_fail_1"
- "aws_opensearch_domain.os_fail_2"
- "aws_elasticsearch_domain.es_fail_2"
- "aws_elasticsearch_domain.es_fail_1"
8 changes: 4 additions & 4 deletions tests/terraform/graph/checks/resources/OpenSearchDomainHasFineGrainedControl/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
resource "aws_opensearch_domain" "os_fail_1" {
resource "aws_opensearch_domain" "os_pass1" {
domain_name = "ggkitty"
engine_version = "Elasticsearch_7.1"

Expand Down Expand Up @@ -44,7 +44,7 @@ resource "aws_opensearch_domain" "os_fail_2" {
}

advanced_security_options {
enabled = true
enabled = false
anonymous_auth_enabled = true
internal_user_database_enabled = false
master_user_options {
Expand Down Expand Up @@ -118,7 +118,7 @@ resource "aws_elasticsearch_domain" "es_fail_1" {
}

advanced_security_options {
enabled = true
enabled = false
anonymous_auth_enabled = true
internal_user_database_enabled = false
master_user_options {
Expand Down Expand Up @@ -164,7 +164,7 @@ resource "aws_elasticsearch_domain" "es_pass" {
}

advanced_security_options {
enabled = true
enabled = false
anonymous_auth_enabled = true
internal_user_database_enabled = true
master_user_options {
Expand Down
Loading