fix(terraform): dont move clone to internal dir #7159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omriyoffe-panw
approved these changes
May 15, 2025
Contributor
|
@lirshindalman can you add a test? |
Contributor
@tsmithv11 Added unit tests |
bo156
reviewed
May 18, 2025
bo156
approved these changes
May 19, 2025
Saarett
pushed a commit
that referenced
this pull request
May 20, 2025
* dont move clone to iined dir * add unit tests --------- Co-authored-by: lshindelman <lshindelman@paloaltonetworks.com> Co-authored-by: Omri Yoffe <oyoffe@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
since we're already using inner_module when building dest_dir, there's no need to add it again after cloning.
like in this example - git::github.com/terraform-aws-modules/security-group/aws//modules/http-80
as this 'git::**https://**github.com/terraform-aws-modules/terraform-aws-security-group'