这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(terraform): support CLI notation in CKV_AZURE_228 for EventHub locations #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025
Merged

fix(terraform): support CLI notation in CKV_AZURE_228 for EventHub locations #7124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e64610e
fix(terraform): support CLI notation in CKV_AZURE_228 for EventHub lo…
tberreis Apr 24, 2025
c3fb042
Add test
tsmithv11 Apr 25, 2025
7f61c22
Merge branch 'main' into main
tsmithv11 Apr 25, 2025
a728ddf
fix flake8
tsmithv11 Apr 25, 2025
6a464c5
Merge branch 'main' of https://github.com/tberreis/checkov into pr/7124
tsmithv11 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 42 additions & 11 deletions checkov/terraform/checks/resource/azure/EventHubNamespaceZoneRedundant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,48 @@
from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceValueCheck

LOCATIONS_W_REDUNDANCY = [
"Brazil South", "France Central", "Qatar Central", "South Africa North", "Australia East",
"Canada Central", "Italy North", "UAE North", "Central India",
"Central US", "Germany West Central", "Israel Central", "Japan East",
"East US", "Norway East", "Japan West",
"East US 2", "North Europe", "Southeast Asia",
"South Central US", "UK South", "East Asia",
"US Gov Virginia", "West Europe", "China North 3",
"West US 2", "Sweden Central", "Korea Central",
"West US 3", "Switzerland North", "New Zealand North",
"Mexico Central", "Poland Central",
"Spain Central"
# Asia Pacific
"Australia East", "australiaeast",
"Central India", "centralindia",
"China North 3", "chinanorth3",
"East Asia", "eastasia",
"Indonesia Central", "indonesiacentral",
"Japan East", "japaneast",
"Japan West", "japanwest",
"Korea Central", "koreacentral",
"New Zealand North", "newzealandnorth",
"South Africa North", "southafricanorth",
"Southeast Asia", "southeastasia",
# Canada
"Canada Central", "canadacentral",
# Europe
"France Central", "francecentral",
"Germany West Central", "germanywestcentral",
"Italy North", "italynorth",
"North Europe", "northeurope",
"Norway East", "norwayeast",
"Poland Central", "polandcentral",
"Spain Central", "spaincentral",
"Sweden Central", "swedencentral",
"Switzerland North", "switzerlandnorth",
"UK South", "uksouth",
"West Europe", "westeurope",
# Mexico
"Mexico Central", "mexicocentral",
# Middle East
"Israel Central", "israelcentral",
"Qatar Central", "qatarcentral",
"UAE North", "uaenorth",
# South America
"Brazil South", "brazilsouth",
# US
"Central US", "centralus",
"East US", "eastus",
"East US 2", "eastus2",
"South Central US", "southcentralus",
"US Gov Virginia", "usgovvirginia",
"West US 2", "westus2",
"West US 3", "westus3"
]


Expand Down
16 changes: 16 additions & 0 deletions tests/terraform/checks/resource/azure/example_EventHubNamespaceZoneRedundant/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@ resource "azurerm_eventhub_namespace" "pass" {
}
}

resource "azurerm_resource_group" "pass2" {
name = "pass2-resources"
location = "australiaeast"
}

resource "azurerm_eventhub_namespace" "pass2" {
name = "pass2-eventhubns"
location = azurerm_resource_group.pass2.location
resource_group_name = azurerm_resource_group.pass2.name
sku = "Standard"
capacity = 2
tags = {
environment = "Production"
}
}

resource "azurerm_eventhub_namespace" "unknown" {
name = "unknown-eventhubns"
location = azurerm_resource_group.foo.location
Expand Down
1 change: 1 addition & 0 deletions tests/terraform/checks/resource/azure/test_EventHubNamespaceZoneRedundant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def test(self):

passing_resources = {
'azurerm_eventhub_namespace.pass',
'azurerm_eventhub_namespace.pass2',
}
failing_resources = {
'azurerm_eventhub_namespace.fail',
Expand Down
Loading