fix(general): Make --download-external-modules Optional[bool] #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bd7fc3 to
962abec
Compare
962abec to
59cb91b
Compare
Contributor
|
@thentenaar thanks for the contribution! Can you please fix the flake8 findings? |
tsmithv11
approved these changes
Apr 26, 2025
59cb91b to
6f1781f
Compare
maxamel
approved these changes
Apr 27, 2025
This allows --download-external-modules to evaluate to: - True if set to true - False if set to false - None as the default value ... which enables the modules code to check whether the value was explicitly set, or is merely the default. Also, don't print the message about the flag being required if it has been explicitly set to false.
6f1781f to
7d4b133
Compare
Saarett
pushed a commit
that referenced
this pull request
Apr 28, 2025
This allows --download-external-modules to evaluate to: - True if set to true - False if set to false - None as the default value ... which enables the modules code to check whether the value was explicitly set, or is merely the default. Also, don't print the message about the flag being required if it has been explicitly set to false. Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This allows
--download-external-modulesto evaluate to:which enables the modules code to check whether the value was explicitly set, or is merely the default.
Also, don't print the message about the flag being required if it has been explicitly set to false.
Fixes #5782
Checklist: