fix(terraform_plan): use provider name not resource address to fix supported_provider matching #7119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @alanszlosek looks like a great contribution, thanks! Can you add the example you shared in the issue #7118 as a test? |
…e address internally
83ea29c to
f499a63
Compare
Contributor
Author
Hi @tsmithv11 I've updated the PR with some multi-provider Terraform and a new test. This felt like it should be an end-to-end type of test to me, where we need to ensure the parser is creating internal data structures correctly such that provider checks run for all relevant providers and pass/fail as expected. I know I didn't make any changes to the runner, but I created the test in the runner folder. Is that ok with you? |
tsmithv11
approved these changes
May 6, 2025
bo156
approved these changes
May 6, 2025
Saarett
pushed a commit
that referenced
this pull request
May 6, 2025
…pported_provider matching (#7119) fix supported_provider matching: use provider name instead of resource address internally Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
|
@alanszlosek hey I know you! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fix matching of
supported_providervalues.Use the provider name (not the key from the plan which can contain the provider alias) in the provider_map data structure, since this is what
supported_provideris compared against. Otherwise, some provider checks will only run against providers without an alias.Fixes #7118
Checklist: