feat(terraform): Over permissive Lambda Cors check (Terraform & Cloudformation) #7113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxamel
reviewed
Apr 20, 2025
| - "AWS::Lambda::Url.ValidLambdaUrlOnlyMethodsStar" | ||
| fail: | ||
| - "AWS::Lambda::Url.InvalidLambdaUrl" | ||
| evaluated_keys: |
Contributor
There was a problem hiding this comment.
what is the purpose of the evaluated keys here?
Contributor
Author
There was a problem hiding this comment.
I didn't find any documentation about this field but I assume it asserts that the evaluated keys are the same keys that has an attribute field in the check yaml itself.
So if for example I ensured that the attribute AllowOrigins doesn't contain * it should appear in the tests evaluated_keys (otherwise the tests fail)
tsmithv11
suggested changes
Apr 20, 2025
Contributor
tsmithv11
left a comment
There was a problem hiding this comment.
Looks good! The resource type we want to filter on is the function
checkov/cloudformation/checks/graph_checks/LambdaOpenCorsPolicy.yaml
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/aws/LambdaOpenCorsPolicy.yaml
Outdated
Show resolved
Hide resolved
6b8a796 to
17977cd
Compare
…ambda_function_url
try-panwiac
reviewed
Apr 22, 2025
checkov/cloudformation/checks/graph_checks/LambdaOpenCorsPolicy.yaml
Outdated
Show resolved
Hide resolved
tsmithv11
approved these changes
Apr 22, 2025
becc4d4 to
bd43493
Compare
bd43493 to
235a21a
Compare
bo156
approved these changes
Apr 22, 2025
| check_list.sort(reverse=True, key=lambda s: int(s.split('_')[-1])) | ||
|
|
||
| for i in range(1, len(aws_checks) + 3): | ||
| for i in range(1, len(aws_checks) + 2): |
Contributor
There was a problem hiding this comment.
He added the same check to 2 frameworks, so they need the same ID
lirshindalman
approved these changes
Apr 22, 2025
OfekShimko
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This PR adds graph checks for over permissive AWS Lambda CORS (Cross-Origin Resource Sharing) both for Terraform and Cloudformation.
This check aligns to the run policy ID
7bf83882-02ad-4f79-803c-ed4588e166cdNew/Edited policies (Delete if not relevant)
Description
AWS Lambda URL resource (
aws_lambda_function_url/AWS::Lambda::Url) that is connected to a lambda resource (aws_lambda_function_url/AWS::Lambda::Function) can't have bothallow_origins: *andallow_methods: *Fix
Define at least one
allow_originsorallow_methodsas non*valueChecklist: