fix(general): base_runner: Properly escape excluded directories that begin with '.' #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a9f459 to
4c6a85e
Compare
…begin with '.' In case the repo has been checked out to a path that inadvertently matches one of the excluded directory patterns (i.e. .git), we should check for it, and escape the pattern via ``re.escape()`` instead of just escaping the leading '.' in '.terraform'. Otherwise, this causes some tests to fail if the repo is checked out to ``~/git/checkov``, as this would match the '.git' excluded directory by virtue of the leading '.' not being escaped.
4c6a85e to
28924ec
Compare
try-panwiac
approved these changes
Apr 23, 2025
tsmithv11
approved these changes
Apr 23, 2025
omriyoffe-panw
approved these changes
Apr 24, 2025
Saarett
pushed a commit
that referenced
this pull request
Apr 24, 2025
…begin with '.' (#7112) In case the repo has been checked out to a path that inadvertently matches one of the excluded directory patterns (i.e. .git), we should check for it, and escape the pattern via ``re.escape()`` instead of just escaping the leading '.' in '.terraform'. Otherwise, this causes some tests to fail if the repo is checked out to ``~/git/checkov``, as this would match the '.git' excluded directory by virtue of the leading '.' not being escaped.
Saarett
pushed a commit
that referenced
this pull request
Apr 24, 2025
…begin with '.' (#7112) In case the repo has been checked out to a path that inadvertently matches one of the excluded directory patterns (i.e. .git), we should check for it, and escape the pattern via ``re.escape()`` instead of just escaping the leading '.' in '.terraform'. Otherwise, this causes some tests to fail if the repo is checked out to ``~/git/checkov``, as this would match the '.git' excluded directory by virtue of the leading '.' not being escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
In case the repo has been checked out to a path that inadvertently matches one of the excluded directory patterns (i.e. .git), we should check for it, and escape the pattern via
re.escape()instead of just escaping the leading '.' in '.terraform'.Otherwise, this causes some tests to fail if the repo is checked out to
~/git/checkov, as this would match the '.git' excluded directory by virtue of the leading '.' not being escaped.Checklist: