-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(terraform): 7 new policies #7056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithv11
suggested changes
Mar 22, 2025
Contributor
tsmithv11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left some comments. Also:
- Please add in the description the CKV ID to Prisma Cloud ID mapping
- Make sure the tests pass
- Add evaluated_keys or get_evaluated_keys
checkov/terraform/checks/resource/aws/AutoScalingGroupWithPublicAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/S3BucketPubliclyReadableViaACL.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/S3BucketPubliclyReadableViaACL.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/UnpatchedAuroraPostgresDB.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/WAFv2VulnerableForLog4j.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/WAFv2VulnerableForLog4j.py
Outdated
Show resolved
Hide resolved
…icAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
…nUsernameAndPublicAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
…ViaACL.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
…B.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
…essible.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com>
…from-CSPM' into feat(terraform)-medium-policies-from-CSPM
…from-CSPM' into feat(terraform)-medium-policies-from-CSPM # Conflicts: # checkov/terraform/checks/resource/aws/EMRPubliclyAccessible.py # checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py # checkov/terraform/checks/resource/aws/S3BucketPubliclyReadableViaACL.py # checkov/terraform/checks/resource/aws/WAFv2VulnerableForLog4j.py
tsmithv11
reviewed
May 13, 2025
checkov/terraform/checks/graph_checks/aws/ALBWebACLConfiguredWIthLog4jVulnerability.yaml
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/aws/ALBWebACLConfiguredWIthLog4jVulnerability.yaml
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/AutoScalingGroupWithPublicAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/S3AccessPointPubliclyAccessible.py
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/aws/S3BucketPubliclyReadableViaACL.yaml
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/aws/AppsyncWebACLConfiguredWIthLog4jVulnerability.yaml
Show resolved
Hide resolved
checkov/terraform/checks/graph_checks/aws/APIGatewayWebACLConfiguredWIthLog4jVulnerability.yaml
Show resolved
Hide resolved
tsmithv11
approved these changes
May 16, 2025
tsmithv11
approved these changes
May 18, 2025
bo156
reviewed
May 19, 2025
checkov/terraform/checks/graph_checks/aws/ALBWebACLConfiguredWIthLog4jVulnerability.yaml
Outdated
Show resolved
Hide resolved
…ithub.com/bridgecrewio/checkov into feat(terraform)-medium-policies-from-CSPM
bo156
approved these changes
May 19, 2025
Saarett
pushed a commit
that referenced
this pull request
May 19, 2025
* 7 new policies * Update checkov/terraform/checks/resource/aws/AutoScalingGroupWithPublicAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/EMRPubliclyAccessible.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/S3BucketPubliclyReadableViaACL.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/UnpatchedAuroraPostgresDB.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/WAFv2VulnerableForLog4j.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/S3AccessPointPubliclyAccessible.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * changes due to @taylor comments * pre-commit warnings fixed * update due to Taylor comments * delete auto created init file * delete auto created init file * delete python test file * fix expected failures * Switch class * Fixes * fix flake8 * fix tests * Update IDs * fix id --------- Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> Co-authored-by: Taylor <tsmith.v11@gmail.com>
Saarett
pushed a commit
that referenced
this pull request
May 19, 2025
* 7 new policies * Update checkov/terraform/checks/resource/aws/AutoScalingGroupWithPublicAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/EMRPubliclyAccessible.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/RedshiftClusterWithCommonUsernameAndPublicAccess.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/S3BucketPubliclyReadableViaACL.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/UnpatchedAuroraPostgresDB.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/WAFv2VulnerableForLog4j.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * Update checkov/terraform/checks/resource/aws/S3AccessPointPubliclyAccessible.py Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> * changes due to @taylor comments * pre-commit warnings fixed * update due to Taylor comments * delete auto created init file * delete auto created init file * delete python test file * fix expected failures * Switch class * Fixes * fix flake8 * fix tests * Update IDs * fix id --------- Co-authored-by: Taylor <28880387+tsmithv11@users.noreply.github.com> Co-authored-by: Taylor <tsmith.v11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
974cbc1a-d26b-4465-bbdc-991edf2a334b8d65d3b7-75f2-4628-b07b-ab574041dbdfefecd50f-5a1f-4d6d-b862-8e760b9612e48336772f-d32c-4a8f-9c72-0ae7dcb637e90bcfdab2-31d8-4dc9-a91c-42c7a7242e014482eb7e-513a-4620-922f-16f495fbc4b0b1b718d8-e62e-497d-80f2-2baa66a4f8bdc69f2020-a640-4df1-91fc-f1a14e480cb8Checklist: