这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@achiar99
Copy link
Contributor

@achiar99 achiar99 commented Mar 17, 2022

Add connected node data to graph check record, to be able create remediation for graph checks violations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please also add 1-2 UTs 🙂

@achiar99 achiar99 changed the title add connected node data to graph check record Add connected node data to graph check record Mar 17, 2022
@achiar99 achiar99 requested a review from gruebel March 17, 2022 20:24
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥇

@gruebel gruebel merged commit fe2ade9 into master Mar 18, 2022
@gruebel gruebel deleted the add-connected-node-to-record branch March 18, 2022 09:37
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
* add connected node data to graph check record

* add tests

* eof
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
* add connected node data to graph check record

* add tests

* eof
@achiar99 achiar99 restored the add-connected-node-to-record branch March 23, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants