AWS Kinesis firehose - Delivery streams are encrypted #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Mar 16, 2022
Contributor
gruebel
left a comment
There was a problem hiding this comment.
Should we also put this exception in the check
Server-side encryption should not be enabled when a kinesis stream is configured as the source of the firehose delivery stream.
Contributor
Author
|
you're not wrong. fixed it. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
* Delivery stream are encrypted * Not valid if kinesis is the source
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
* Delivery stream are encrypted * Not valid if kinesis is the source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.