Fix entropy-keyword plugin to use analyze_line #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemavni
approved these changes
Jul 14, 2021
Collaborator
rotemavni
left a comment
There was a problem hiding this comment.
@nimrodkor Great unit tests!
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
detect-secret's plugins require you to create a
analyze_string, but this specific plugin needs to leverage the logic in the underlying plugins'analyze_line. Changed implementation accordingly.