这是indexloc提供的服务,不要输入任何密码
Skip to content

feat(metadata-editor): package bump for new icons #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

box-catzhang
Copy link
Contributor

@box-catzhang box-catzhang commented Jul 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated dependency versions for improved compatibility and latest features.

@box-catzhang box-catzhang requested a review from a team as a code owner July 18, 2025 16:58
Copy link

coderabbitai bot commented Jul 18, 2025

Walkthrough

The package.json file was modified to update the versions of two dependencies: "@box/blueprint-web-assets" and "@box/metadata-editor" in both devDependencies and peerDependencies sections. No other dependencies or scripts were changed.

Changes

File(s) Change Summary
package.json Bumped "@box/blueprint-web-assets" from ^4.53.0 to ^4.60.0 and "@box/metadata-editor" from ^0.117.0 to ^0.122.0 in devDependencies and peerDependencies.

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • tjuanitas
  • cghil

Poem

A hop and a skip, dependencies rise,
Blueprint and metadata, reaching new highs.
No scripts disturbed, just versions anew,
A gardener’s update, fresh morning dew.
With every small bump, our code hops ahead—
🐇 Package.json, your carrots are fed!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6d778c and 0fd302c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: tjuanitas
PR: box/box-ui-elements#4126
File: scripts/webpack.config.js:72-76
Timestamp: 2025-06-17T15:21:36.180Z
Learning: The Box UI Elements project does not run webpack builds on Windows machines, so Windows path separator compatibility is not a concern for their build scripts.
package.json (1)
Learnt from: rafalmaksymiuk
PR: box/box-ui-elements#4160
File: src/elements/content-sidebar/SidebarToggle.js:21-27
Timestamp: 2025-06-25T13:09:54.538Z
Learning: The box-ui-elements project uses Flow for type annotations in JavaScript files, as indicated by @flow directives in file headers. Type annotations like `: Props` are valid Flow syntax, not TypeScript syntax.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: lint_test_build
  • GitHub Check: Summary
🔇 Additional comments (2)
package.json (2)

124-137: Dependency bumps are internally consistent – run install & update lockfile

Both devDependencies and peerDependencies are bumped in tandem for
@box/blueprint-web-assets (→ ^4.60.0) and @box/metadata-editor (→ ^0.122.0).
👍 This keeps local builds and downstream consumers aligned.

Action items:

  1. yarn install --frozen-lockfile to refresh yarn.lock.
  2. Commit the regenerated lock file so CI picks up the new versions.
  3. Add an entry to CHANGELOG noting the new icon package so integrators know to pull the latest assets.

289-298: Double-check cross-package compatibility before releasing

I tried running the icon-diff script, but it failed because node_modules/@box/blueprint-web-assets wasn’t present (peer deps aren’t installed by default) and comm isn’t available in this environment. Please:

• Install or link your peer dependencies (e.g. npm install @box/blueprint-web-assets@4.60.0) so you can run the check locally.
• Confirm there are no renamed or removed icons between 4.53 → 4.60 that your code relies on—any missing icon will cause rendering breaks.

You can use this revised script once the package is installed:

#!/bin/bash
# Ensure @box/blueprint-web-assets@4.60.0 is in node_modules/

# 1. List all blueprint icon class names in src/
rg -o --no-heading --no-line-number 'bp-icon-[A-Za-z0-9-]+' src | sort -u > /tmp/icons_used.txt

# 2. List all icons shipped in blueprint-web-assets
rg -o --no-heading --no-line-number 'bp-icon-[A-Za-z0-9-]+' node_modules/@box/blueprint-web-assets | sort -u > /tmp/icons_available.txt

# 3. Show any icons you use that aren’t available upstream
grep -Fxv -f /tmp/icons_available.txt /tmp/icons_used.txt

An empty output ⇒ safe to upgrade. Otherwise, update your code or pin to a compatible assets version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot merged commit 1506020 into box:master Jul 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants