src/api/uploads/BaseUpload.js (1)

33-33: Consider type annotation consistency.

The type annotation is functionally correct, but uses double quotes while the corresponding TypeScript interface uses single quotes. Consider using single quotes for consistency across the codebase.

-    overwrite: boolean | "error";
+    overwrite: boolean | 'error';

Note: The static analysis hint about "return types can only be used in TypeScript files" is incorrect - this is valid Flow syntax for property type annotations in JavaScript files.

🧰 Tools

🪛 Biome (1.9.4)

[error] 33-33: return types can only be used in TypeScript files

remove this type annotation

(parse)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/MultiputUpload.js (1)

1243-1255: ⚠️ Potential issue

resolveConflict ignores the new 'error' mode – will overwrite instead of erroring

this.overwrite is treated as a truthy flag; when it contains 'error', the condition still passes and we proceed with the overwrite path, breaking the contract introduced by this PR.

-    async resolveConflict(data: Object): Promise<any> {
-        if (this.overwrite && data.context_info) {
+    async resolveConflict(data: Object): Promise<any> {
+        // Honour the new mode – surface the conflict immediately.
+        if (this.overwrite === 'error') {
+            this.errorCallback(data);
+            return;
+        }
+
+        if (this.overwrite && data.context_info) {
             this.fileId = data.context_info.conflicts.id;
             return;
         }

Without this guard, any chunked upload using 'error' will silently overwrite the existing file – the exact behaviour we’re trying to avoid.

🧰 Tools

🪛 Biome (1.9.4)

[error] 1245-1245: Illegal return statement outside of a function

(parse)

---

[error] 1249-1249: Illegal return statement outside of a function

(parse)

src/api/uploads/PlainUpload.js (1)

139-141: JSDoc is now stale – update the param doc for overwrite
The type has changed to accept 'error', but the preceding JSDoc (lines 118-120) still reads @param {boolean}. Keeping docs in sync prevents confusion for integrators.

- * @param {boolean} [overwrite] - Should upload overwrite file with same name
+ * @param {boolean|'error'} [overwrite] - Conflict behaviour. true=overwrite, false=rename, 'error'=fail

🧰 Tools

🪛 Biome (1.9.4)

[error] 139-139: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 140-140: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 141-141: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 139-139: Shouldn't redeclare 'overwrite'. Consider to delete it or rename it.

'overwrite' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 140-140: Shouldn't redeclare 'progressCallback'. Consider to delete it or rename it.

'progressCallback' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 141-141: Shouldn't redeclare 'successCallback'. Consider to delete it or rename it.

'successCallback' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 140-140: Don't use 'Function' as a type.

Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.

(lint/complexity/noBannedTypes)

---

[error] 141-141: Don't use 'Function' as a type.

Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.

(lint/complexity/noBannedTypes)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/MultiputUpload.js (1)

339-346: ⚠️ Potential issue

Retry continues even after signalling fatal conflict – causes unwanted loops

createSessionErrorHandler always calls createSessionRetry() after resolveConflict().
When overwrite === 'error', resolveConflict (lines 1241-1244) already triggers errorCallback and should terminate the flow, but control returns to createSessionErrorHandler, which then schedules another retry.
This results in an unnecessary retry loop and multiple error callbacks.

@@
-        if (errorData && errorData.status === 409) {
-            this.resolveConflict(errorData);
-            this.createSessionRetry();
-            return;
-        }
+        if (errorData && errorData.status === 409) {
+            if (this.overwrite === 'error') {
+                this.errorCallback(errorData);
+                return;
+            }
+            this.resolveConflict(errorData);
+            this.createSessionRetry();
+            return;
+        }

Alternatively, make resolveConflict return a boolean indicating whether the caller should continue.

Also applies to: 1241-1244

src/api/uploads/PlainUpload.js (1)

118-121: JSDoc no longer matches the new overwrite contract

The docblock still describes overwrite as boolean-only and omits the new 'error' mode, while the Flow annotation (line 139) correctly allows boolean | 'error'. Please update the comment so that consumer-facing documentation and IDE hints stay in sync.

- * @param {boolean} [overwrite] - Should upload overwrite file with same name
+ * @param {boolean|'error'} [overwrite] - true → overwrite, false → auto-rename, 'error' → fail on conflict

Also applies to: 137-140

src/api/uploads/MultiputUpload.js (1)

170-186: Outdated JSDoc after adding 'error' overwrite mode

All three public entry points (setFileInfo, upload, resume) now accept boolean | 'error', but the surrounding comments still document the parameter as a plain boolean. This creates confusion for integrators and future maintainers.

- * @param {boolean} [overwrite]
+ * @param {boolean|'error'} [overwrite]

Apply the same tweak to the other two blocks above.

Also applies to: 213-233, 433-451

🧰 Tools

🪛 Biome (1.9.4)

[error] 179-183: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 184-184: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 185-185: optional parameters are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 185-185: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 186-186: optional parameters are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 186-186: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.

TypeScript only syntax

(parse)

---

[error] 184-184: Shouldn't redeclare 'folderId'. Consider to delete it or rename it.

'folderId' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 185-185: Shouldn't redeclare 'overwrite'. Consider to delete it or rename it.

'overwrite' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 186-186: Shouldn't redeclare 'progressCallback'. Consider to delete it or rename it.

'progressCallback' is defined here:

(lint/suspicious/noRedeclare)

---

[error] 180-180: Don't use 'Function' as a type.

Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.

(lint/complexity/noBannedTypes)

---

[error] 181-181: Don't use 'Function' as a type.

Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.

(lint/complexity/noBannedTypes)

---

[error] 186-186: Don't use 'Function' as a type.

Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.

(lint/complexity/noBannedTypes)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/MultiputUpload.js (2)

221-231: Same duplication comment as above

See previous note – the same cast appears here.

🧰 Tools

🪛 Biome (1.9.4)

[error] 223-223: expected , but instead found :

Remove :

(parse)

---

[error] 224-224: expected , but instead found conflictCallback

Remove conflictCallback

(parse)

---

[error] 224-224: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 225-225: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 226-226: expected , but instead found :

Remove :

(parse)

---

[error] 227-227: expected , but instead found fileDescription

Remove fileDescription

(parse)

---

[error] 227-227: expected , but instead found :

Remove :

(parse)

---

[error] 228-228: expected , but instead found fileId

Remove fileId

(parse)

---

[error] 228-228: expected , but instead found :

Remove :

(parse)

---

[error] 229-229: expected , but instead found folderId

Remove folderId

(parse)

---

[error] 229-229: expected , but instead found :

Remove :

(parse)

---

[error] 230-230: expected , but instead found overwrite

Remove overwrite

(parse)

---

[error] 230-230: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 231-231: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

441-450: Same duplication comment as above

See previous note – the same cast appears here.

🧰 Tools

🪛 Biome (1.9.4)

[error] 443-443: expected , but instead found :

Remove :

(parse)

---

[error] 444-444: expected , but instead found conflictCallback

Remove conflictCallback

(parse)

---

[error] 444-444: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 445-445: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 446-446: expected , but instead found :

Remove :

(parse)

---

[error] 447-447: expected , but instead found fileId

Remove fileId

(parse)

---

[error] 447-447: expected , but instead found :

Remove :

(parse)

---

[error] 448-448: expected , but instead found folderId

Remove folderId

(parse)

---

[error] 448-448: expected , but instead found :

Remove :

(parse)

---

[error] 449-449: expected , but instead found overwrite

Remove overwrite

(parse)

---

[error] 449-449: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 450-450: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

src/api/uploads/BaseUpload.js (1)

33-34: Add doc-block/propType update for new union type

overwrite is now boolean | 'error', but that isn’t documented anywhere in the file header or in consumer-facing JSDoc. A quick comment explaining the three modes (overwrite, rename, hard-error) will make the API self-describing.

🧰 Tools

🪛 Biome (1.9.4)

[error] 33-33: return types can only be used in TypeScript files

remove this type annotation

(parse)

src/api/uploads/MultiputUpload.js (1)

176-186: Default-parameter cast is fine, but consider centralising

The (true: boolean | 'error') cast is now repeated in setFileInfo, upload, and resume. Extracting a small constant, e.g.:

const DEFAULT_OVERWRITE: boolean | 'error' = true;

would remove duplication and the slightly awkward Flow cast.

🧰 Tools

🪛 Biome (1.9.4)

[error] 176-176: expected ) but instead found :

Remove :

(parse)

---

[error] 176-176: expected , but instead found |

Remove |

(parse)

---

[error] 176-176: expected , but instead found )

Remove )

(parse)

---

[error] 176-176: Expected a class method body but instead found ','.

Expected a class method body here.

(parse)

---

[error] 177-177: expected a semicolon to end the class property, but found none

(parse)

---

[error] 177-177: Expected an identifier, a string literal, a number literal, a private field name, or a computed name but instead found ','.

Expected an identifier, a string literal, a number literal, a private field name, or a computed name here.

(parse)

---

[error] 178-178: expected a semicolon to end the class property, but found none

(parse)

---

[error] 178-178: Expected an identifier, a string literal, a number literal, a private field name, or a computed name but instead found ','.

Expected an identifier, a string literal, a number literal, a private field name, or a computed name here.

(parse)

---

[error] 179-179: Expected a statement but instead found ':'.

Expected a statement here.

(parse)

---

[error] 180-180: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 181-181: Expected an expression, or an assignment but instead found ':'.

Expected an expression, or an assignment here.

(parse)

---

[error] 182-182: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)

src/api/uploads/PlainUpload.js (1)

131-132: Same ‘Flow cast’ duplication comment

The (true: boolean | 'error') pattern appears in three upload classes. Consider extracting a shared constant as noted in MultiputUpload.

🧰 Tools

🪛 Biome (1.9.4)

[error] 131-131: expected ) but instead found :

Remove :

(parse)

---

[error] 131-131: expected , but instead found |

Remove |

(parse)

---

[error] 131-131: expected , but instead found )

Remove )

(parse)

---

[error] 131-131: Expected a class method body but instead found ','.

Expected a class method body here.

(parse)

---

[error] 132-132: Expected a statement but instead found ':'.

Expected a statement here.

(parse)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/MultiputUpload.js (3)

221-233: Same suppression repeat – apply cast pattern
See previous comment; apply the same fix here.

---

443-453: Third occurrence – remove $FlowFixMe
Consistent fix as above.

---

341-345: Retry still scheduled after fatal conflict – duplicate error callbacks possible
resolveConflict now bails out early when overwrite === 'error', yet the caller immediately schedules createSessionRetry(). This results in:

1. errorCallback firing once in resolveConflict
2. A retry, followed by additional failures / callbacks.

Prevent the redundant retry:

-            if (errorData && errorData.status === 409) {
-                this.resolveConflict(errorData);
-                this.createSessionRetry();
-                return;
-            }
+            if (errorData && errorData.status === 409) {
+                if (this.overwrite === 'error') {
+                    this.errorCallback(errorData);
+                    return;
+                }
+                this.resolveConflict(errorData);
+                this.createSessionRetry();
+                return;
+            }

src/api/uploads/BaseUpload.js (2)

33-35: Union type addition looks correct, but please document the tri-state clearly
The field now accepts boolean | 'error'; consider updating the file-level JSDoc (top of file) so other engineers immediately understand the three behaviours.

---

161-166: Short-circuit branch added – consider extracting literal 'error' to a constant
The early return correctly prevents retries when overwrite === 'error'. To avoid future typos and make IDE refactors easier, introduce a shared constant, e.g.

+export const OVERWRITE_MODE_ERROR = 'error';
...
- if (this.overwrite === 'error') {
+ if (this.overwrite === OVERWRITE_MODE_ERROR) {

src/api/uploads/MultiputUpload.js (1)

176-187: Flow suppression can be removed – cast the default instead of $FlowFixMe
Explicitly cast the default value to the union to keep CI green without suppressions:

-        // $FlowFixMe
-        overwrite = true,
+        overwrite: boolean | 'error' = (true: boolean),

Repeat for the other overloads below.

src/api/uploads/PlainUpload.js (3)

119-120: JSDoc updated – consider mirroring wording used in other upload classes
To keep docs consistent across upload helpers, reuse the phrasing from BaseUpload/MultiputUpload.

---

131-133: Avoid $FlowFixMe by casting default
Same pattern as MultiputUpload:

-        // $FlowFixMe
-        overwrite = true,
+        overwrite: boolean | 'error' = (true: boolean),

This keeps Flow happy without suppressions.

---

140-141: Parameter type redeclaration warning – harmless but avoidable
The type of overwrite is redeclared in the object-type annotation; removing it there eliminates Biome’s “noRedeclare” noise:

-        overwrite: boolean | 'error',
+        overwrite: boolean | 'error',

(only one declaration required)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/MultiputUpload.js (1)

176-187: Consider dropping the repeated // $FlowFixMe and using an explicit param type instead

Three different method signatures still rely on a // $FlowFixMe to silence Flow around the default value for overwrite. Since the parameter is now explicitly typed as boolean | 'error', Flow should accept the default without complaint on current builds. Removing the pragma keeps the codebase cleaner and makes future Flow/TS migrations easier.

-        // $FlowFixMe
-        overwrite = true,
+        overwrite: boolean | 'error' = true,

Repeat the same change in upload() and resume().

If the old Flow version still errors, a local type alias can be introduced instead of scatter-shot suppressions:

type OverwriteMode = boolean | 'error';

This trims noise while retaining type safety.

Also applies to: 221-233, 446-457

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/api/uploads/PlainUpload.js (1)

131-133: Avoid blanket // $FlowFixMe; cast the default instead

overwrite already accepts a boolean, so Flow can be satisfied without suppressing the type checker:

-        // $FlowFixMe
-        overwrite = true,
+        overwrite = (true: boolean | 'error'),

This removes a global suppression comment, keeps the intent explicit, and prevents accidental masking of unrelated Flow errors in the future.

src/api/uploads/BaseUpload.js (1)

162-165: Consider cleaning up the upload object after emitting the conflict error

When overwrite === 'error' you invoke errorCallback and return, but the upload object (timers, XHR handles, workers) remains alive. This can leak resources if the consumer does not call cancel() manually.

-            if (this.overwrite === 'error') {
-                this.errorCallback(errorData);
-                return;
-            }
+            if (this.overwrite === 'error') {
+                this.errorCallback(errorData);
+                this.destroy(); // prevent stray retries / listeners
+                return;
+            }

Please verify this aligns with how callers expect the lifecycle to behave.

src/api/uploads/MultiputUpload.js (2)

176-178: Replace repeated // $FlowFixMe with a typed default

Same suggestion as for PlainUpload: casting the default value keeps the type-checker happy without suppressing it.

-        // $FlowFixMe
-        overwrite = true,
+        overwrite = (true: boolean | 'error'),

Apply to every constructor/overload where the pattern occurs to reduce noise and future maintenance risk.

Also applies to: 221-223, 446-448

---

342-345: Early-exit branch still leaves the session object alive

Mirroring the concern in BaseUpload, returning after errorCallback means any pending retry timers (createSessionTimeout) stay scheduled. Add a cleanup to avoid duplicate error surfaces and wasted bandwidth:

-                if (this.overwrite === 'error') {
-                    this.errorCallback(errorData);
-                    return;
-                }
+                if (this.overwrite === 'error') {
+                    this.errorCallback(errorData);
+                    this.destroy();
+                    return;
+                }

Double-check that calling destroy() here will not break UI expectations (e.g., cancel buttons, progress components).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro